Skip to content
This repository was archived by the owner on Jan 3, 2023. It is now read-only.
This repository was archived by the owner on Jan 3, 2023. It is now read-only.

CJS support and other onLoad returns #1

Description

@AndrewLeedham

Hi, I love the idea of this package. esbuild has always been missing piped plugins IMO. I ran into a few issues trying to add support to unplugin and vanilla-extract:

  1. The package only ships ESM, so in some environments it is not usable, my specific use case was a vite.config.ts file, as they are transpiled to CJS before running.
  2. Errors/warnings/loader and other onLoad returns are lost between each plugin. Perhaps errors/warnings can be concatenated and the loader can be retained from the last plugin or derived from the file name?

Curious if you are open to accepting PRs for some of the above. I know adding new feature can add maintenance overhead, so don't want to spend the time adding things without your blessing 🙂

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions