Avoid writing Stream spec.tls with empty values #321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes the corresponding struct field a pointer with "omitempty" so that it is not written back to the API server when updating metadata with finalizer and annotations.
yhrn
commented
Dec 10, 2025
Comment on lines
+115
to
+118
| // After we have added the finalizer, we need to requeue to make sure we reconcile the | ||
| // rest of the object. Just updating metadata won't make the API server update generation | ||
| // so the update above shouldn't trigger a new reconciliation. | ||
| return ctrl.Result{Requeue: true}, nil |
Author
There was a problem hiding this comment.
The problem that this PR is supposed to fix was the reason this ever worked
Author
|
I also wonder if there are more struct fields in But on the other hand, I don't even understand why you can configure TLS on a Stream so I need some help deciding what is right and wrong here. If I do get that help I'm happy ta add such fixes to this PR though. |
Author
|
Is there any chance I could get some feedback on this one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes the corresponding struct field a pointer with "omitempty" so that it is not written back to the API server when updating metadata with finalizer and annotations.
This is a followup to #263, which was not fully fixed by #297