Fix runtime calculation regressions and config cache sync - #78
Open
Ethan-Wang-dev wants to merge 1 commit into
Open
Ethan-Wang-dev wants to merge 1 commit into
Ethan-Wang-dev wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes several runtime regressions found while exercising the public calculation APIs under the dependencies currently pinned by the project.
planet_listcorrectly inplanetary_positions()and preserve public planet IDs.local_time_to_jdut1()and use the supportedcal=keyword forswe.utc_to_jd().include_uranus_to_plutosetting key;HoroscoperaiseValueErrorfor missing location input instead of printing and terminating the process.placetodrik.vaara()when building calendar information.The stable integration facade maintained in the fork is intentionally not included in this PR.
Tests
Added focused regression coverage for every item above, including an actual
get_calendar_information()call and config cache transitions.