Skip to content

Various improvements - #2

Open
davidortinau wants to merge 1 commit into
naweed:mainfrom
davidortinau:maui7alt
Open

Various improvements#2
davidortinau wants to merge 1 commit into
naweed:mainfrom
davidortinau:maui7alt

Conversation

@davidortinau

@davidortinau davidortinau commented Oct 27, 2022

Copy link
Copy Markdown

Here are some alternate choices that workaround the bugs impacting this project.

  • Using ScrollView+HorizontalStackLayout+BindableLayout instead of CollectionView
  • Using one NavigationPage instead of replacing the MainPage (if preventing back nav is desired, we can address that also -- Shell does this easily)
  • Using Fullscreen flag instead of translucent status bar for Android (it was leaving a white gap in my emulator)
  • Padding instead of Margin where margin causes layout to miscalculate
  • Cleaned up csproj (VS clutters it sadly)

image

image

image

image

@naweed

naweed commented Jan 5, 2023

Copy link
Copy Markdown
Owner

Hi David,

As mentioned earlier in the private messages, here is my feedback (for everyone's benefit):

  • Using ScrollView+HorizontalStackLayout+BindableLayout instead of CollectionView
    Yes, we can do it when we have fewer items to work with. But this does not offer virtualization. CollectionView is always better for latge number of items. In this case, we can use the technique suggested by you since the number of items are limited. But regardless, this issue should be address in SDK itself.

  • Using one NavigationPage instead of replacing the MainPage (if preventing back nav is desired, we can address that also -- Shell does this easily)
    Regarding the use of MainPage replacement, I am not a huge fan of Shell. I believe that these are two different patterns/choices available to users. This is working fine in Xamarin, and also worked fine until Maui GA SR-1. It broke in SR-2. So, this is a bug that needs to be fixed. And, can you suggest the alternative as you mentioned above.

  • Using Fullscreen flag instead of translucent status bar for Android (it was leaving a white gap in my emulator)
    This is not an option for the required UI. The FullScreen mode will not work in this case. What I want to achieve is not FullScreen but Transparent Status Bar. I want to continue showing the status bar and not break normal user experience. FullScreen will work if I am building a video playing app, but this is not the case for me.

  • Padding instead of Margin where margin causes layout to miscalculate
    Margins and Paddings should be used for outside and inside spacing respectively as a rule. This might be a short-term solution for now, but this needs to be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants