Make every installer verifiable instead of asking for trust - #6
Merged
Conversation
An unsigned 168 MB installer from an unknown GitHub account is, on its
face, indistinguishable from malware — and "the project is open source"
does not answer that, because the source is not what anyone downloaded.
Nothing tied the binary on the release page to the code in this repo.
The release workflow now signs a SLSA build-provenance attestation for
every installer *before* it uploads it, so the digest that is attested is
the digest that ships:
gh attestation verify <installer> -R nazmiefearmutcu/flowmap
That is public and Sigstore-backed: it names the workflow, the run and the
commit the file was built from, and a failure means the file did not come
from here. Alongside it, each leg emits its checksum lines and the publish
job collects them into one SHA256SUMS release asset — the check that needs
no tooling at all (`shasum -a 256 -c SHA256SUMS`).
The file list is now resolved once and reused by the attestation, the
checksums and the upload, so those three cannot drift apart.
SECURITY.md writes down what the app actually does: loopback-only bind
(non-loopback FLOWMAP_HOST is rejected, not accepted quietly), no
telemetry, no wallet or trading keys, no auto-updater, the exact outbound
endpoints per market, and what it writes to disk. The README now leads
with running from source, and the unsigned-app warning points at the
verification step instead of just telling people to click past it.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A Reddit reply to the project was, in full: "AKA how to get malware on your pc."
That is a fair reaction to the front door as it stood. The README's first move was: download a
168 MB unsigned
.dmg/.exefrom an unknown GitHub account, then click past your OS's warning(
xattr -cr, SmartScreen → Run anyway). "It's open source" does not answer it — the source isnot what anyone downloaded, and nothing connected the binary on the release page to the code in
this repo.
This closes that gap rather than arguing about it.
What changed
Build provenance (
.github/workflows/release.yml). Every installer is signed with a SLSAbuild-provenance attestation before it is uploaded, so the attested digest is the shipped digest.
Public and Sigstore-backed — it names the workflow, run and commit the file came from:
A failure means the file did not come from this repository.
SHA256SUMS. Each matrix leg emits its checksum lines as a workflow artifact; thepublishjob collects them into a single release asset, so
shasum -a 256 -c SHA256SUMSworks with notooling. (A parallel matrix can't produce one combined file on its own — hence the artifact hop.)
One file list. The installer list is resolved once (
Collect the produced installers) and reusedby the attestation, the checksums and the upload, so those three can't drift apart.
SECURITY.md— what the app actually does, all verifiable in-tree: loopback-only bind(a non-loopback
FLOWMAP_HOSTraisesValueError, it isn't quietly accepted), no telemetry,no wallet/trading keys, no auto-updater or shell plugin, the exact outbound endpoints per market,
what it writes to disk and the 20 GB cap, what's inside the installer, and a private-advisory
reporting path.
README —
## Installnow leads with running from source, a### Verify your downloadsectionsits directly under the download table, and the unsigned-app note points at the verification step
instead of only telling people how to click past the warning.
Notes
SHA256SUMScover the next tagged release onward; v1.3.0's assets predatethem and will not verify. SECURITY.md and the README both say so explicitly.
buildjob:id-token: write+attestations: write.publishgainsactions: readfordownload-artifact.attest-build-provenance@0f67c3f(v4),upload-artifact@043fb46(v7),download-artifact@3e5f45b(v8).do_release == 'true', so aworkflow_dispatchdry-run build isunaffected.
Verification
yaml.safe_loadparses the workflow; job/step graph checked.shellcheck -s bashclean on all four new/changedrun:blocks.(unmerged
download-artifactlayout included):shasum -a 256 -c SHA256SUMS→OK.semgrep p/github-actions p/secrets— 48 rules, 0 findings.run on a real release.