feat: add terminology toggle for fakie/forward trick names - #52
Merged
Conversation
Adds a terminology parameter to generate_combo (and Trick.to_dict): 'classic' (default) keeps canonical Front/Back names; 'fakie' renders Front X -> Forward X and Back X -> Fakie X, per skater feedback. Only the name field changes; ids and state values stay canonical. Closes #37 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…wn styles Review finding (agy counter-review): generate_combo raised ValueError for unknown terminology but Trick.to_dict silently fell back to classic names. Sharing the check in _display_name makes both paths fail loudly. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Data fixes (moves.json, data version 1.1.0 -> 1.2.0): - Every name now follows 'Front/Back [Open|Closed] Move' (Eccentric Inline convention); turns gain their Front prefix, '(Stance)' suffix form is gone - Simplified ids: predator_f_o -> predator_f, parallel_turn_* -> parallel_*, tree_turn_* -> tree_* - Toe/heel rolls and fast/back slides corrected to feet: 1 with matching exit.feet: 1 Tests and docs updated to the new names/ids; with all names prefixed, the fakie terminology style now maps every move. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
terminologykeyword ongenerate_combo(andTrick.to_dict):"classic"(default, unchanged output) or"fakie"(Front X→Forward X,Back X→Fakie X), per the user feedback in user feedback #37Parallel Turn (Open)) are unchanged in both stylesnamefield changes —idand all entry/exit state values keep the canonicalfront/backvocabulary, so matching logic and downstream state consumers are unaffectedValueErrorFully backward compatible — default output is byte-identical to v0.5.0.
Note: merge after #50/#51; the import-line change is textually identical to #51's so the merge resolves cleanly.
Closes #37
Test plan
ruff check .,black --check .,mypy .(strict),pytest— all green locally (41 passed)generate_combo(4, terminology='fakie')→Fakie Fast Slide, Fakie Toe Press, Fakie 180, Forward Heel Press🤖 Generated with Claude Code