feat: add trick argument to guarantee a named move in the combo - #54
Merged
Conversation
generate_combo(trick='Front Open Gazelle') always includes that move: it is woven in the first time the state machine can reach it, falling back to anchoring it as the first trick. Matching is case-insensitive, accepts fakie wording (Forward/Fakie prefixes) and small typos via difflib; unknown names raise ValueError with suggestions. An explicit trick wins over max_stage while the stage filter still applies to the rest of the pool. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
trickkeyword ongenerate_combo: the named move is guaranteed to appear in the resultForward Open Gazelle,Fakie 540) mapped back to canonical prefixes, small typos matched viadifflib(cutoff 0.75); unknown names raiseValueErrorwith did-you-mean suggestionstrickwins overmax_stage(the stage filter still applies to every other move)_build_chainso the fallback rebuild reuses the exact same cascade; 7 new testsTest plan
ruff,black,mypy(strict),pytest— all green locally (50 passed)'forward open gazele'), stage-clash (Front 540atmax_stage=1), unknown-name error🤖 Generated with Claude Code