Fix renderer warnings#609
Draft
bluepilledgreat wants to merge 2 commits into
Draft
Conversation
Contributor
|
size_t is not the same as unsigned int on 64 bit anything |
Contributor
Author
was thinking of 32-bit platforms when writing that, whoops |
BrentDaMage
approved these changes
May 12, 2026
Member
BrentDaMage
left a comment
BrentDaMage
left a comment
There was a problem hiding this comment.
Code looks good, however I'd like to test with an ancient version of Xcode first on my Power Mac G5, since I had to make a lot of changes for the JsonParsers initially for that exact reason.
Member
|
Code builds fine on the G5. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
unsigned intinstead ofsize_t. Even though they're both technically the same, MSVC does not like mismatching typedefs and their actual types._renderStateTypeMapbeing defined twice