fix: remove nightly-only feature attributes#1
Merged
Merged
Conversation
nberlette
commented
Dec 20, 2025
Owner
- fix: remove nightly-only feature attributes
- fix(cow_str): remove unstable const impls from CowStr
- docs(cow_str): add safety documentation to unsafe CowStr methods
- tests(cow_str): remove duplicate InlineStr tests from CowStr
- fix(inline_str): respect feature-gated derive_more impls
- fix(inline_str): remove unstable const impls
- docs(inline_str): add safety and panic info to InlineStr docs
- tests(inline_str): improve InlineStr tests for 32-bit targets
- deps: add serde_json to dev dependencies for tests
- chore: bump version
- ci: add check/release workflow
There was a problem hiding this comment.
Pull request overview
This PR stabilizes the codebase by removing nightly-only Rust features and improving documentation for unsafe operations. Key changes include removing unstable const trait implementations, adding comprehensive safety documentation to unsafe methods, and improving test coverage for 32-bit architectures.
- Removes nightly-only feature gates (
const_convert,const_index,const_trait_impl) to stabilize the crate - Adds safety documentation to all unsafe methods in
CowStrandInlineStr - Improves test coverage with platform-specific tests for 32-bit targets
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/lib.rs | Removes nightly-only feature attributes to enable stable Rust compilation |
| src/inline_str.rs | Removes unstable const implementations, adds safety docs, makes derive_more features optional, and adds 32-bit tests |
| src/cow_str.rs | Removes unstable const implementations, adds safety documentation to unsafe methods, and removes duplicate tests |
| Cargo.toml | Bumps version to 0.2.0 and adds serde_json dev dependency |
| .github/workflows/ci.yml | Adds comprehensive CI/CD workflow for checking, testing, and releasing |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.