Make InlineStr From<&T> infallible and non-panicking#6
Draft
Copilot wants to merge 2 commits into
Draft
Conversation
Copilot
AI
changed the title
[WIP] Fix From impl in inline_str.rs to ensure compliance
Make Jun 17, 2026
InlineStr From<&T> infallible and non-panicking
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InlineStrhad aFrom<&T>implementation that could panic on oversized input, violatingFrom’s infallibility contract. This change removes that panic path and aligns behavior with other infallibleInlineStrconversions.Problem alignment
From<&T>(expect(...)ontry_from) with an infallible conversion strategy.Conversion semantics
impl<T: AsRef<str>> From<&T> for InlineStrnow:MAX_INLINE_STR_LENCoverage added
From<&T>:&strreference path&Stringreference path