Repository navigation
Conversation
… bug pass Mirror of snapetech-org/seerrng#595 (lumen/ changes only; the PR also updates docs/using-seerr/lumen.md in SeerrNG). Closes here once merged upstream and synced.
Owner
Author
|
Merged upstream in snapetech-org/seerrng#595 (v3.72.21) with two follow-up fixes from the maintainer. lumen/ here is synced to it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirror of snapetech-org/seerrng#595 so testers can read and try it here. Only the
lumen/part is mirrored; the SeerrNG PR also updates the install guide atdocs/using-seerr/lumen.md.Don't merge this here: it closes once SeerrNG merges #595 and the sync brings it into
lumen/.Three commits on top of main (d48de130).
1. Use the full width of large screens
The page stopped at 1320px and posters stayed 164px wide, so a wide monitor showed a narrow column with empty space on both sides. Past 1600px the content now grows with the window (up to 1680, 2400 and 3200px), and posters, feature cards and genre tiles grow with it. Nothing changes below 1600px except the gutter fix below.
The base
--gutterwas defined inlumen.css, which loads afterapp.css. It silently overrodeapp.css's 32px (tablet) and 40px (desktop) gutters, so every screen got 20px. It now lives inapp.csswith the other layout tokens, so those gutters apply as designed.2. Clearer address names, and a working "open full SeerrNG" link
SEERR_INTERNAL_URLSEERR_URLSEERR_BROWSER_URLSEERR_FULL_URLdeploy/05-lumen-env-aliases.envshmaps the new names before nginx renders its templates. When both are set, the new name wins. The compose files, README and install guide now use the new names, with a note that the old ones still work."Open full SeerrNG" used to fall back to
http://localhost:5070(a dev address) whenlumen-config.jsonset noseerrPublicUrl, and the not-found page ignoredseerrPublicUrlentirely. The fallback is now/seerrng, which Lumen's nginx redirects toSEERR_FULL_URL, and the not-found page uses the configured address.3. Bug and UI pass
Testing
npm run build,tsc --noEmit, unit tests, and Playwright on desktop/iPhone/Android/tablet: 235 passed, 13 skipped (desktop-only and device-only cases)./seerrng.SEERR_FULL_URLalone,SEERR_BROWSER_URLalone, and both set (new wins) all redirect/seerrngand/settings/...correctly.SEERR_INTERNAL_URLchangesproxy_pass.