Repository navigation
Test coin refill at the exact one-hour boundary - #318
Merged
Merged
Conversation
Pin that a balance whose last_refill_at is exactly one hour before now is refilled, guarding both <= comparisons in refill_coin_balances. Fixes #312
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
tests/unit/test_token_refill.py: newtest_refills_at_exact_one_hour_boundary. A balance withlast_refill_at = now - 1his refilled once on the next pass (coins_left50 -> 60,last_refill_at == now).CHANGELOG.md: one line under[Unreleased].No production code change.
How it was tested
uv run pytest tests/unit/test_token_refill.py -x: 15 passed.uv run pytest: 2443 passed, 147 skipped. The full PostgreSQL + Redis run is this PR's CI.lumen/services/token_refill.py:34(select of due balances)<=changed to<: the new test fails.lumen/services/token_refill.py:110(UPDATE guard)<=changed to<: the new test fails.Fixes #312