modeling: rebuild PEFT envoy paths on environment swap - #728
Open
koriyoshi2041 wants to merge 1 commit into
Open
koriyoshi2041 wants to merge 1 commit into
koriyoshi2041 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
peft=and that stale root paths are gonePEFT retains the base model as a descendant of its wrapper. Without clearing the old registry entries, rebuilding reuses Envoys carrying pre-wrap paths and never constructs the
base_model.modelsubtree.Closes #726.
Tests
test_set_env_transitionsreportedmodel.transformer.h.0instead ofmodel.base_model.model.transformer.h.0CUDA_VISIBLE_DEVICES="" pytest tests/test_language.py::TestPeft -q— 5 passedgit diff --check