bin/pyda: quote app-args passthrough so target args survive#67
Open
s8lvg wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
bin/pydapasses the target program's arguments through an unquoted${@:2}.Bash field-splits an unquoted expansion on
$IFSand globs it, so any targetargument containing spaces, tabs, newlines, or glob characters is mangled
before it reaches the target.
Reproduce
A no-op tool (
noop.py):Run a target with a single argument that contains spaces:
Expected (one argument):
Actual (argument split into three):
Same cause also globs:
pyda noop.py -- /bin/echo '*'prints the directorylisting instead of a literal
*.Fix
Quote the expansion:
"${@:2}"expands each positional parameter as its ownword, verbatim, with no splitting or globbing. Also quote
"$PYDA_TOOL_PATH"for paths with spaces.