Skip to content

Code review #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bgamba10 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Code review #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
<meta charset="utf-8">
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<title>Nicolas Cabrera</title>
<!-- bibiana gamba: la descripción debe ser de la página, es útil tener el meta de author también-->
<meta name="description" content="An interactive getting started guide for Brackets.">
<link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootstrap/3.3.6/css/bootstrap.min.css"/>
<link rel="stylesheet" href="main.css">
Expand Down Expand Up @@ -99,6 +100,8 @@ <h4 class="letreros">FestivAndes</h4>
<div class="container">
<div class="row text-center">
<h2 class="tituloCategorias"><u>Skills</u></h2>
<!-- bibiana gamba: este div puede ser extra, a veces no es buena práctica tener tantos divs,
es mejor tratar de organizar el espacio únicamente con los necesarios -->
<div class="container logos">
<div class="col-md-3">
<div class="row">
Expand Down Expand Up @@ -181,4 +184,4 @@ <h2><u>Contact</u></h2>
<script src="./scripts.js"></script>
<script defer src="https://use.fontawesome.com/releases/v5.0.6/js/all.js"></script>
</body>
</html>
</html>