Import NekInfoPostprocessor for NekCI test suite#1213
Import NekInfoPostprocessor for NekCI test suite#1213nandu90 wants to merge 370 commits intoneams-th-coe:develfrom
Conversation
New postprocessor: NekInfoPostprocessor
|
Thanks @nandu90! I just sent you an invite to join the |
|
You'll also want to rebase your |
|
I have accepted the invite. Thanks! I am not sure which permission you mentioned. Do you mean to nandu90/cardinal ? Should i add you as collaborator on that fork? |
|
Yes, if you make me a collaborator on nandu/cardinal then I can push directly there (or if you prefer, I can open a pull request to your fork but IMO this will be a bit easier and save you some time if you let me update it directly). I can do the rebase part for you |
|
Sure! just sent an invite for collaborator access |
|
got it, thanks! will work on this soon |
|
sorry, accidentally hit close |
|
@nandu90, are there any tests which use the |
|
All of them are in nek_ci. I am not sure how I would create one without a nek case. |
|
We will need to have test cases in the repo itself, since this will be a valid object users can use and we are not considering nek_ci to be part of the code requirements. The object is pretty simple so I can create those tests. |
|
Thanks @aprilnovak appreciate your time for creating these tests. If there is anything that you would like to see changes in |
| } | ||
|
|
||
| // Mesh - X minimum value | ||
| else if (_test_type == "xmin") { |
There was a problem hiding this comment.
FYI these mesh operations will not be robust if running in parallel - I think these all need MPI communication to find the min/max coordinate across all ranks. Will fix this in the new version.
3 participants
Details of the postprocessor are described in nandu90#1