Fix functor system with ExternalProblem-derived classes#1270
Fix functor system with ExternalProblem-derived classes#1270nuclearkevin wants to merge 7 commits intoneams-th-coe:develfrom
Conversation
|
Fighting a DAGMC build failure (CMake can't seem to find HDF5 in CIVET). We'll see if this works or not... |
aed1616 to
5bfd5e6
Compare
5bfd5e6 to
15980f1
Compare
786d82e to
2318c14
Compare
|
Still don't know why DAGMC is failing to find HDF5 from MOAB. There might be an issue with the CIVET recipe; thoughts @aprilnovak? |
Can you check that the new output file looks physically correct? (no weird nodal values?) you may need to increase the number of time steps to let it run until reaching pseudo steady-state. As for the CIVET failure, I have no idea - nothing has changed with the test recipe and we just merged Walid's PR yesterday (which ran the test suite fine). Can we narrow it down to the MOOSE update? (e.g. could try separating out the transfer update from this PR into its own) |
Left is the new transfer, right is the old gold file - they look pretty much identical (no matter how I slice the results). Also ran Exodiff on the two meshes - a handful of nodes are off by ~1e-3 or less.
I'll open a new PR with just the submodule update to isolate the build issue. Also building on Pinchot at the moment to attempt to replicate the failure in an environment I have access to. Update: I cannot replicate the build issue on Pinchot and #1272 (just the MOOSE submodule update) fails standalone. |
83e8b63 to
d2b8f63
Compare
d2b8f63 to
c1a8fa3
Compare
5078844 to
f1a953e
Compare
f1a953e to
ca7b653
Compare

This PR also modifies a test to ensure we hit this in the future.
Closes #1269