Skip to content

Fix functor system with ExternalProblem-derived classes#1270

Open
nuclearkevin wants to merge 7 commits intoneams-th-coe:develfrom
nuclearkevin:fix_functor_pp
Open

Fix functor system with ExternalProblem-derived classes#1270
nuclearkevin wants to merge 7 commits intoneams-th-coe:develfrom
nuclearkevin:fix_functor_pp

Conversation

@nuclearkevin
Copy link
Contributor

@nuclearkevin nuclearkevin commented Jan 9, 2026

This PR also modifies a test to ensure we hit this in the future.

Closes #1269

@nuclearkevin nuclearkevin marked this pull request as draft January 9, 2026 22:38
@nuclearkevin
Copy link
Contributor Author

nuclearkevin commented Jan 9, 2026

Fighting a DAGMC build failure (CMake can't seem to find HDF5 in CIVET). We'll see if this works or not...

@nuclearkevin nuclearkevin marked this pull request as ready for review January 10, 2026 18:53
@nuclearkevin nuclearkevin force-pushed the fix_functor_pp branch 3 times, most recently from 786d82e to 2318c14 Compare January 10, 2026 22:34
@nuclearkevin
Copy link
Contributor Author

MultiAppNearestNodeTransfer is depreciated in MOOSE and throws an error if used. MultiAppGeneralFieldNearestLocationTransfer is the new version of that transfer, however it results in a diff which necessitated a regold.

Still don't know why DAGMC is failing to find HDF5 from MOAB. There might be an issue with the CIVET recipe; thoughts @aprilnovak?

@aprilnovak
Copy link
Collaborator

MultiAppNearestNodeTransfer is depreciated in MOOSE and throws an error if used. MultiAppGeneralFieldNearestLocationTransfer is the new version of that transfer, however it results in a diff which necessitated a regold.

Can you check that the new output file looks physically correct? (no weird nodal values?) you may need to increase the number of time steps to let it run until reaching pseudo steady-state.

As for the CIVET failure, I have no idea - nothing has changed with the test recipe and we just merged Walid's PR yesterday (which ran the test suite fine). Can we narrow it down to the MOOSE update? (e.g. could try separating out the transfer update from this PR into its own)

@nuclearkevin
Copy link
Contributor Author

nuclearkevin commented Jan 11, 2026

Can you check that the new output file looks physically correct? (no weird nodal values?) you may need to increase the number of time steps to let it run until reaching pseudo steady-state.

Left is the new transfer, right is the old gold file - they look pretty much identical (no matter how I slice the results). Also ran Exodiff on the two meshes - a handful of nodes are off by ~1e-3 or less.
Screenshot from 2026-01-11 11-32-28

As for the CIVET failure, I have no idea - nothing has changed with the test recipe and we just merged Walid's PR yesterday (which ran the test suite fine). Can we narrow it down to the MOOSE update? (e.g. could try separating out the transfer update from this PR into its own)

I'll open a new PR with just the submodule update to isolate the build issue. Also building on Pinchot at the moment to attempt to replicate the failure in an environment I have access to.

Update: I cannot replicate the build issue on Pinchot and #1272 (just the MOOSE submodule update) fails standalone.

@nuclearkevin nuclearkevin force-pushed the fix_functor_pp branch 2 times, most recently from 5078844 to f1a953e Compare January 16, 2026 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Using (AD)ElementIntegralFunctorPostprocessor with a tally variable yields a crash

2 participants