This repository was archived by the owner on Oct 4, 2024. It is now read-only.
Add ability to generate secp256k1 keys #863
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikedotexe
suggested changes
Nov 2, 2021
Contributor
mikedotexe
left a comment
mikedotexe
left a comment
There was a problem hiding this comment.
Similar to how we have the optional yolo argument, let's please add the curveType so that yargs knows about it.
(Like here:
near-cli/commands/generate-key.js
Lines 9 to 12 in 4cf5e36
volovyks
reviewed
Nov 24, 2021
| @@ -1,3 +1,4 @@ | |||
| const keyCurveTypes = require('near-api-js').keyCurveTypes; | |||
Collaborator
There was a problem hiding this comment.
@TarasenkoFirelabs this line gives me undefined.
And as a result: TypeError: Cannot read property 'validate' of undefined
Author
There was a problem hiding this comment.
I am still working onto this task in near-api-js repo
Collaborator
There was a problem hiding this comment.
Got it, then it's better to keep this one in a draft. Ping me when it will be ready for review, thanks!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solved issue #855
Note that we already have this in the Rust SDK:
https://github.com/near/near-sdk-rs/blob/2e979934cca7c87a5ca5d7dcb62e4b3cbe809afc/near-sdk/src/types/public_key.rs#L10
and
https://github.com/near/near-sdk-rs/blob/1a706b2eb0dd3e96e2ba4f6e74b0ef972c4bbbdf/sys/src/lib.rs#L38
and
https://github.com/near/nearcore/blob/a20c12ec02d7f22550139da38838efd1fba75ede/runtime/near-vm-logic/src/logic.rs#L976