DRAFT - Add explicit ability to disable external Nebi integration - #192
Open
kenafoster wants to merge 1 commit into
Open
DRAFT - Add explicit ability to disable external Nebi integration#192kenafoster wants to merge 1 commit into
kenafoster wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a nebi.enabled master switch to cleanly disable integration with an external nebari-nebi-pack (while keeping the in-pod Nebi binary behavior driven by nebi.image.tag).
Changes:
- Introduces
nebi.enabled(defaulttrue) invalues.yamland documents intended downstream effects. - Updates Helm helper templates so
nebiRemoteURL/nebiInternalURLrender empty whennebi.enabled: false. - Gates the hub→nebi NetworkPolicy on
nebi.enabled(but currently still gates on the rawnebi.internalURLvalue rather than the derived helper output).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| values.yaml | Adds nebi.enabled and documents how it disables external nebi-pack integration surfaces. |
| templates/_helpers.tpl | Makes nebiRemoteURL/nebiInternalURL helpers return empty when nebi.enabled is false. |
| templates/hub-nebi-networkpolicy.yaml | Adds nebi.enabled to the NetworkPolicy condition (but needs adjustment to match derived internal URL behavior). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -1,4 +1,4 @@ | |||
| {{- if and .Values.nebi.internalURL .Values.nebi.namespace }} | |||
| {{- if and .Values.nebi.enabled .Values.nebi.internalURL .Values.nebi.namespace }} | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
nebi.enabledmaster switch to disable separate-pack integrationAdds a single
nebi.enabledflag (default true, so no change to existing deployments) that cleanly disables integration with a separatenebi-packdeployment. When set to false, the nebiRemoteURL and nebiInternalURL template helpers return empty regardless of any explicit value, which switches off every downstream surface that keys off them:The in-JupyterLab standalone Nebi binary is independent of this flag — it's driven solely by nebi.image.tag and stays fully wired when nebi.enabled: false.
Motivation
The in-JupyterLab Nebi works on its own. The local + remote dual experience introduced by the standalone Nebi pack can be more confusing than helpful for some use cases, and operators should be able to opt out of it without giving up in-lab Nebi. The local Nebi still supports connecting to OCI registries, so teams can still share "approved/curated" environments amongst themselves.
Previously there was no supported way to fully turn off the separate-pack integration from values alone: nebi-internal-url always auto-derived an in-cluster service address, so the environment selector stayed enabled and pointed at a nebi-pack that may not exist — producing failed lookups and log noise with no clean off switch. Disabling it required commenting out multiple unrelated values blocks and still left the derived internal URL active.
Reference Issues or PRs
No explicit call to do this yet, but it relates to:
#50
nebari-dev/nebi#423
What does this implement/fix?
Put a
xin the boxes that applyTesting
Rendered the chart with helm template in both states:
Documentation
TODO: if approved, docs need updating
Access-centered content checklist
Text styling
H1or#in markdown).Non-text content
Any other comments?