Skip to content

fix(lint): drop unused noqa: F821 and fix deployment CI - #207

Merged
aktech merged 2 commits into
mainfrom
fix/ruff-unused-noqa
Aug 6, 2026
Merged

fix(lint): drop unused noqa: F821 and fix deployment CI#207
aktech merged 2 commits into
mainfrom
fix/ruff-unused-noqa

Conversation

@aktech

@aktech aktech commented Aug 5, 2026

Copy link
Copy Markdown
Member

Fixes two failing CI jobs on main.

  • Lint: drop a stale # noqa: F821 on a get_chart_config call ruff already resolves fine (RUF100).
  • Test Deployment: merge-ca-bundle init container's image tag drifted from hub.image after an automated bump; bump_image_tags.py now keeps them in sync, values.yaml resynced once to catch up.

aktech added 2 commits August 5, 2026 13:03
ruff now resolves get_chart_config in this exec namespace, so the
suppression is dead weight and trips RUF100.
The automated tag bump only rewrote hub.image.tag, leaving the
merge-ca-bundle init container's hardcoded image string pinned to a
stale sha and failing test_init_container_uses_hub_image on main.
bump_image_tags.py now rewrites both on every bump; values.yaml is
resynced to the current hub tag as a one-time catch-up.
@aktech aktech changed the title fix(lint): drop unused noqa: F821 on get_chart_config call fix(lint): drop unused noqa: F821 and fix deployment CI Aug 5, 2026
@aktech
aktech marked this pull request as ready for review August 5, 2026 12:27
@aktech
aktech requested a review from pmeier as a code owner August 5, 2026 12:27
@aktech

aktech commented Aug 6, 2026

Copy link
Copy Markdown
Member Author

merging to fix the broken CI

@aktech
aktech merged commit 572b550 into main Aug 6, 2026
14 checks passed
@aktech
aktech deleted the fix/ruff-unused-noqa branch August 6, 2026 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants