Skip to content

fix(#455): map filter.type to statusType on volunteer entity#544

Merged
arturasmckwcz merged 3 commits into
developfrom
fix/455-volunteer-type-filter
May 21, 2026
Merged

fix(#455): map filter.type to statusType on volunteer entity#544
arturasmckwcz merged 3 commits into
developfrom
fix/455-volunteer-type-filter

Conversation

@nadavosa
Copy link
Copy Markdown
Collaborator

Summary

  • getVolunteerWhere was spreading { type: ... } but the TypeORM volunteer entity field is statusType, not type
  • This caused the volunteer type filter (Regular / Accompanying / Events) to always return zero results
  • One-line fix: rename the key from type to statusType

Related

Test plan

  • Apply volunteer type filter "Regular" — should return only regular volunteers
  • Apply volunteer type filter "Events" — should return only events volunteers
  • Verify existing accompanying toggle still works (it already used statusType correctly)

🤖 Generated with Claude Code

nadavosa and others added 2 commits May 20, 2026 14:58
The volunteer entity field is `statusType`, not `type`. This bug caused
the volunteer type filter to always return zero results.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The workaround unconditionally prepended "vol-" to engagement filter
values, but the FE may send values with the prefix already present
(e.g. "vol-temp-unavailable"). This produced "vol-vol-temp-unavailable"
which never matched any DB record, returning 0 results.

Now the prefix is only added if the value doesn't already start with "vol-".

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@arturasmckwcz arturasmckwcz merged commit 0ba27bf into develop May 21, 2026
@arturasmckwcz arturasmckwcz deleted the fix/455-volunteer-type-filter branch May 21, 2026 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: filtering volunteers by volunteer type returns no results

2 participants