fix: add loading placeholder to dashboard list pages#541
Merged
need4deed merged 4 commits intoMay 20, 2026
Merged
Conversation
…payload appointmentDistrict is server-calculated from the postcode and should never be sent by the client. The display now reads the localized district title directly from the API response and renders it as "<postcode>, <district>" in a single row. The separate district field is removed from both the display and edit views, and the field is dropped from the PATCH payload type and form schema. Changes: - useUpdateOpportunityAccompanyingDetails: remove appointmentDistrict from payload type - accompanyingDetailsSchema: remove appointmentDistrict field - helpers: remove appointmentDistrict from getInitialFormValues - AccompanyingDetailsEdit: remove district Controller and its three props - AccompanyingDetails: compute postcodeDisplay from opportunity.accompanyingDetails using localized Option title with de fallback; drop appointmentDistrict from onSubmit - AccompanyingDetailsDisplay: merge postcode and district into one row using postcodeDisplay prop
Dashboard Volunteer, Opportunity, and Agent lists had no loading state, causing a layout shift and giving the impression of empty results while data was being fetched. Each list controller now shows a centred loading message with a min-height placeholder while isLoading is true. Changes: - Add shared DashboardListLoading component with min-height container - VolunteerListController: destructure isLoading, return placeholder while loading - OpportunityListController: same - AgentListController: same
nadavosa
approved these changes
May 19, 2026
Collaborator
nadavosa
left a comment
nadavosa
left a comment
There was a problem hiding this comment.
Clean and correct. One thing to verify before merging: confirm that the translation key dashboard.home.content.loading exists in both locale files — it is not in this diff. If it is already there, good to go.
…ing conflicts - VolunteerListController: keep DashboardListLoading guard (Cy-fox) + VolunteerTableList/TABLE_LIMIT (develop) - AccompanyingDetails: keep district/postcode display (Cy-fox) + TranslatedIntoType import (develop) - AccompanyingDetailsDisplay: keep postcodeDisplay prop - helpers.ts: use develop's formatTimeForDisplay (form state already local) and direct appointmentPostcode access Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #424
Dashboard Volunteer, Opportunity, and Agent lists had no loading state, causing a layout collapse and giving the impression of empty results while data was being fetched from the API. Each list controller now returns a centred loading message with a min-height container while isLoading is true, preventing the layout shift.
Changes: