fix: replace accompanying toggle with multi-select volunteer type accordion#552
Open
nadavosa wants to merge 1 commit into
Open
fix: replace accompanying toggle with multi-select volunteer type accordion#552nadavosa wants to merge 1 commit into
nadavosa wants to merge 1 commit into
Conversation
…ordion Remove the binary "Accompanying" switch filter. The existing volunteer-type accordion (ACCOMPANYING, REGULAR, EVENTS, REGULAR_ACCOMPANYING) already covers the same use-case with finer control — no separate boolean needed. Cleans up CardsFilter type, default filter constant, serializer, deserializer, and helpers accordingly. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CardsFiltertype,defaultVolunteerCardsFilter,serializeFilters,deserializeVolunteerFilters,createFilterItems,createSelectedFilterItemsAsFlatArrayDepends on: need4deed-org/be#558 (BE removes
accompanyingboolean from schema)Test plan
🤖 Generated with Claude Code