🐛 fix(#558): align opportunity card status/matchStatus i18n keys with API values#559
Merged
Merged
Conversation
… API values - Add missing 'opp-inactive' to dashboard.opportunities.status in DE and EN - Rename matchStatus translation keys from 'vol-*' to 'opp-vol-*' to match OpportunityMatchStatusType values returned by the API - Update matchStatusColorMap and matchStatusIconMap keys accordingly Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…pe, ...> Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
ivannissimrch
approved these changes
May 27, 2026
Collaborator
ivannissimrch
left a comment
ivannissimrch
left a comment
There was a problem hiding this comment.
I tested locally, and labels display correctly now instead of the raw keys.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #558
What
The opportunity cards in the dashboard list view were showing raw i18n keys instead of translated labels (e.g.
dashboard.opportunities.matchStatus.opp-vol-no-matches).Why
Two mismatches between what the API returns and what the translations/maps expected:
matchStatuskey prefix — The API returnsOpportunityMatchStatusTypevalues likeopp-vol-no-matches, but translation keys and thematchStatusColorMap/matchStatusIconMapinOpportunityCard.helpers.tsxwere keyed asvol-no-matches(missingopp-prefix). Sot(dashboard.opportunities.matchStatus.opp-vol-no-matches)always fell back to the raw key.Missing
opp-inactive—OpportunityStatusType.INACTIVE = "opp-inactive"had no translation entry in either locale, so inactive opportunities showed the raw key.Changes
public/locales/de/translations.json— renamematchStatuskeysvol-*→opp-vol-*, addopp-inactivepublic/locales/en/translations.json— sameOpportunityCard.helpers.tsx— renamematchStatusColorMap/matchStatusIconMapkeysvol-*→opp-vol-*🤖 Generated with Claude Code