Skip to content

✨ Bump SDK to 0.0.95 to unlock new typed fields#561

Merged
need4deed merged 2 commits into
developfrom
ivannissimrch/refactor/sdk-voidable-types
May 29, 2026
Merged

✨ Bump SDK to 0.0.95 to unlock new typed fields#561
need4deed merged 2 commits into
developfrom
ivannissimrch/refactor/sdk-voidable-types

Conversation

@ivannissimrch
Copy link
Copy Markdown
Collaborator

Description

Bumps need4deed-sdk from ^0.0.85 to 0.0.95 to unlock new typed fields the team needs for ongoing work.

  • email, statusMatch on volunteer list
  • statusMatch, agentTitle, and numberOfVolunteers on the opportunity list

Related Issues

Closes #560

Changes

  • Bump need4deed-sdk ^0.0.85 to 0.0.95
  • Agents/helpers.ts, coerce null to undefined inside getNormalizedAgent
  • Home/NewestOpportunities.tsx, Opportunities/OpportunityListController.tsx coerce filter lookup nulls at call site (?? undefined)
  • AccompanyingDetails/helpers.ts, widen parseDate signature to accept null
  • OrganisationDetails.tsx coerce voidable website to "" in initialFormValues

Checklist

  • WITHIN THE SCOPE OF AN ISSUE; No unnecessary files included
  • Tests added/updated
  • Documentation updated
  • CI passes

Copy link
Copy Markdown
Collaborator

@nadavosa nadavosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean, focused PR — the ?? undefined coercions are the right fix for the new Voidable<T> type in 0.0.95. parseDate signature widening and website || "" fallback both look correct.

One small question: the version pin changed from "^0.0.85" (range) to "0.0.95" (exact, no caret). Was that intentional? If so, worth a note — exact pins mean future yarn install runs won't pick up patch fixes automatically. If it was accidental, change to "^0.0.95" to stay consistent with the rest of the deps.

Everything else LGTM — good to merge once that's clarified.

@nadavosa nadavosa mentioned this pull request May 28, 2026
4 tasks
@ivannissimrch
Copy link
Copy Markdown
Collaborator Author

It was accidental, I just changed to "^0.0.95"

@need4deed need4deed merged commit f5c50e2 into develop May 29, 2026
1 check passed
@need4deed need4deed deleted the ivannissimrch/refactor/sdk-voidable-types branch May 29, 2026 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

✨ Bump SDK to 0.0.95 to unlock new typed fields

3 participants