Skip to content

Expose ask_user_question over MCP for dsh; update Codex ids; v0.1.1 - #385

Merged
neich merged 5 commits into
mainfrom
update
Nov 18, 2026
Merged

neich merged 5 commits into
mainfrom
update

Conversation

@neich

@neich neich commented Nov 18, 2026

Copy link
Copy Markdown
Owner

Summary

Lets dsh: sessions ask the user questions through a new ask_user_question MCP tool, mounts gaviero skill folders into dsh's skill catalog, updates Codex model ids, and bumps the workspace version to 0.1.1.

Changes

  • ask_user_question over MCP: new mcp/ask.rs tool, listed only for loopback-HTTP connections that carry x-gaviero-conversation. Extended mcp/server.rs and mcp/http.rs to support it.
  • Shared ask logic: moved the question/answer plumbing out of tool_agent/tools/ask.rs into a new ask_user.rs module in core, so both the in-process tool agent and MCP use it.
  • dsh session: agent_client_protocol/dsh.rs and permission.rs mount the gaviero MCP server over the HTTP listener, include the conversation header, and mount gaviero skill folders into dsh's skill catalog.
  • TUI: app.rs, controller.rs, observers.rs, agent_chat.rs and session_host/{render,session}.rs now surface and answer these questions through the conversation overlay.
  • Codex: updated model ids in examples and in swarm/backend/{codex,shared}.rs.
  • Version/docs: bumped the workspace version to 0.1.1 (Cargo.toml, Cargo.lock) and updated the READMEs, CLAUDE.md and ARCHITECTURE.md files to match.
  • Tests: added coverage in crates/gaviero-core/tests/acp_client.rs.

Testing

  • git diff --check origin/main...HEAD
  • cargo test — skipped (only runs with --run-tests)

Risks / Notes

  • The test suite was not run for this PR, so the new MCP, ask_user and dsh changes are unverified by CI-style tests.
  • Cargo.lock changed (13 lines), along with a new dependency entry in gaviero-core/Cargo.toml.
  • The branch contains two commits with the same title ("Expose ask_user_question over MCP so dsh sessions can ask the user"). You may want to squash on merge.
  • The full branch diff was too large to review here. This description is based on the commit list and diff stat.

Moves the question schema and validation into a shared module used by
both the in-process tool agent and a new MCP tool. The tool is listed
only on loopback-HTTP connections that carry the conversation header,
parks the TUI question overlay, and dsh's own approval prompt for it is
skipped.
Moves the question schema and validation into a shared module used by
both the in-process tool agent and a new MCP tool. The tool is listed
only on loopback-HTTP connections that carry the conversation header,
parks the TUI question overlay, and dsh's own approval prompt for it is
skipped.
The dsh launch now writes a patch overlay that adds the workspace,
workspace-layer and user-wide skill folders to dsh's skill-filesystem
provider. This keeps dsh's skill tool and available-skills list
consistent with what $name resolves in chat.
Refreshes the Codex model names used in backend code, CLI help and
documentation so the examples match the current model lineup.
Raises the shared crate version to 0.1.1 and refreshes the lockfile
accordingly.
@neich
neich merged commit 048d407 into main Nov 18, 2026
@neich
neich deleted the update branch November 18, 2026 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant