Repository navigation
Conversation
Adds .ort-cache to the rust-cache cache-directories in the CI and release workflows, since rust-cache only saves ~/.cargo and target/ by default. A cdn.pyke.io hiccup can then no longer fail a run that already has the ONNX Runtime binaries cached, and the env comments now explain this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The CI and release workflows set
ORT_CACHE_DIRto a workspace folder (.ort-cache).Swatinem/rust-cacheonly saves~/.cargoandtarget/by default, so that folder was never cached. This change adds it to eachrust-cachestep, so cached runs no longer re-download ONNX Runtime fromcdn.pyke.io. A CDN hiccup should then no longer fail a cached run.Changes
.github/workflows/ci.yml: addcache-directories: .ort-cacheto bothSwatinem/rust-cache@v2steps (the check/clippy job and the Windows test job)..github/workflows/release.yml: addcache-directories: .ort-cacheto therust-cachestep, next to the existing per-targetkey.ORT_CACHE_DIRcomments in both files to describe the new behavior.Testing
git diff --check origin/main...HEADcargo test(skipped: only runs with--run-tests)The workflow changes themselves were not run, so the cache hit behavior is unverified until the workflows run on this branch.
Risks / Notes
cache-directoriesis a relative path, resolved from the workspace root. It matches theORT_CACHE_DIRvalue${{ github.workspace }}/.ort-cache.