VALIDATION ONLY: discriminate PR132 ROCm versioned runtime selection - #21
Closed
nekomario28 wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One-shot hosted A/B evidence carrier. Closed unmerged after discrimination. Base is the clean FlashML-org#132-derived version-selection candidate; head adds only the temporary workflow.
Pinned identities:
45417560beeba896a9b0866e50154d2a7a320b8b0c6c504b39a3cff39842209e4ef708e15f8e76e0d7e96cbaf600233bd762ad549ff77965c9ee8435_toolchain.py,setup.py, andtests/kernels/test_rocm_versioned_runtime_selection.pyHosted A/B result
Run
32813417858, job97697004925: SUCCESS on Ubuntu 24.04.The same regression was applied to both trees:
The job also verified exact carrier/candidate/base ancestry, the old lexical
sorted(library_dir.glob("libamdhip64.so.*"))pattern in the base, exact three-file candidate diff, andgit diff --check.This proves the source/build-selection defect and its correction. It does not claim a physical ROCm linker/runtime outcome or maintainer acceptance. Clean candidate remains
fix/pr132-rocm-versioned-runtime-selection@0c6c504b39a3cff39842209e4ef708e15f8e76e0; carrier is intentionally not merged.