Skip to content

fix(rocm): correct runtime capability and resolution semantics - #34

Draft
nekomario28 wants to merge 1 commit into
review/pr132-head-45417560from
fix/pr132-rocm-correctness-review
Draft

fix(rocm): correct runtime capability and resolution semantics#34
nekomario28 wants to merge 1 commit into
review/pr132-head-45417560from
fix/pr132-rocm-correctness-review

Conversation

@nekomario28

Copy link
Copy Markdown
Owner

Review/delivery carrier for upstream FlashML-org#132

This PR is an upstream FlashML-org#132 correction carrier, not a merge target for this fork's diverged main.

Base review/pr132-head-45417560 is an immutable snapshot of FlashML-org/FreeToken#132 head 45417560beeba896a9b0866e50154d2a7a320b8b. The head commit bbeb65e88201d23604bc6a4c489c881e686dd27a is its direct one-commit child.

Corrections

  1. Use registered-host-pointer capability semantics rather than unified addressing as the proxy for host-pointer identity capability.
  2. Resolve versioned libamdhip64.so.* numerically rather than lexically, sharing the selector across setup/build and JIT discovery.
  3. Key project-owned HIP runtime compatibility links by runtime origin so persistent caches cannot silently retain an old SDK/image target.

Focused regression coverage for the three contracts is included in the same commit.

Existing gfx1101 evidence

Previously validated after composition on RX 7800 XT / gfx1101 with PyTorch 2.11.0+rocm7.2, HIP 7.2.26015, TVM-FFI 0.1.13.post3:

  • focused sandbox suite: 11 passed, 3 skipped
  • focused physical suite: 14 passed
  • _pinned_tensor + _cpu_moe build: PASS
  • physical extension load: PASS
  • compileall: PASS
  • git diff --check: PASS

Claim boundary: focused runtime/build correctness only; no full model serving, NVIDIA parity, multi-GPU RCCL, RDNA4, or performance claim.

Delivery status

Preferred delivery is to the existing upstream FlashML-org#132 author branch/conversation, preserving contributor lineage. Direct cross-fork PR/comment delivery via the currently connected GitHub integration is blocked with 403 Resource not accessible by integration. This carrier keeps the exact minimal delta ready for an authorized GitHub/CLI path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant