Add a separate 2D / 3D View switch - #282
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the renderer hierarchy decided after #281: Three.js is not a thirteenth 2D Style. Instead, the viewer exposes a separate top-level View: 2D / 3D control, while each renderer keeps its own Style space.
Behavior
2Dactive and3D Labas the experimental switch.3D Labactive and2Das the return path.Cosmic; this is intentionally separate from the twelve 2D styles and leaves room for future 3D styles./u/and/three/; no premature route unification.style2d, so switchingGalaxy Hybrid 2D → Cosmic 3D → 2Drestores Galaxy Hybrid rather than resetting the 2D style.style2dis removed again when returning to 2D; Three.jsrender=is never carried into 2D./radial/receive the same View axis.Lab/experimental.Architecture
This deliberately models:
rather than mixing
threejsinto the existing Style enum.Gates
style2drestoration across 2D → 3D → 2D;/radial/route verifies the same architecture;Refs #276.