Skip to content

Always only return external and active categories for stores/product(s) categories #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nelo-jdliauw wants to merge 1 commit into from
Closed

Always only return external and active categories for stores/product(s) categories #528

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions packages/medusa/src/api/store/products/middlewares.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ export const storeProductRoutesMiddlewares: MiddlewareRoute[] = [
delete filters.category_id

if (!isPresent(categoryIds)) {
return
return { is_internal: false, is_active: true }
}

return { id: categoryIds, is_internal: false, is_active: true }
Expand Down Expand Up @@ -92,13 +92,7 @@ export const storeProductRoutesMiddlewares: MiddlewareRoute[] = [
}),
applyDefaultFilters({
status: ProductStatus.PUBLISHED,
categories: (_filters, fields: string[]) => {
if (!fields.some((field) => field.startsWith("categories"))) {
return
}

return { is_internal: false, is_active: true }
},
categories: { is_internal: false, is_active: true } // Always apply this filter

@nelo-jdliauw nelo-jdliauw Sep 18, 2025

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The store/product/[id]/route.ts calls refetch but this filter should propagate

}),
normalizeDataForContext(),
setPricingContext(),
Expand Down
Loading