chore(deps): bump smol-toml and markdownlint-cli - #3
Conversation
Bumps [smol-toml](https://github.com/squirrelchat/smol-toml) to 1.7.2 and updates ancestor dependency [markdownlint-cli](https://github.com/igorshubovych/markdownlint-cli). These dependencies need to be updated together. Updates `smol-toml` from 1.5.2 to 1.7.2 - [Release notes](https://github.com/squirrelchat/smol-toml/releases) - [Commits](squirrelchat/smol-toml@v1.5.2...v1.7.2) Updates `markdownlint-cli` from 0.47.0 to 0.49.1 - [Release notes](https://github.com/igorshubovych/markdownlint-cli/releases) - [Commits](igorshubovych/markdownlint-cli@v0.47.0...v0.49.1) --- updated-dependencies: - dependency-name: smol-toml dependency-version: 1.7.2 dependency-type: indirect - dependency-name: markdownlint-cli dependency-version: 0.49.1 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 161e68a21a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "eslint": "^9.39.2", | ||
| "globals": "^17.1.0", | ||
| "markdownlint-cli": "^0.47.0" | ||
| "markdownlint-cli": "^0.49.1" |
There was a problem hiding this comment.
Keep markdownlint within the supported Node range
When contributors install development dependencies on Node 20—which remains supported by engines and is used by the checked .github/workflows/ci.yml lint job—this upgrade is incompatible because markdownlint-cli@0.49.1 and markdownlint@0.41.1 require Node 22 or newer. Reproducing with Node 20.20.2 and npm ci --ignore-scripts --engine-strict exits with EBADENGINE, while non-strict installs leave the lint job invoking an unsupported CLI. Retain a Node-20-compatible release or update the package engine and CI runtimes together.
Useful? React with 👍 / 👎.
neocody
left a comment
There was a problem hiding this comment.
Verdict: no blocking findings, but this PR touches a sensitive area - a human-approved session must merge it.
Automated Claude Code review (Opus, high effort, fresh context, PR head checked out with repo tools) posted by pr-shepherd because this PR looked stuck: open >1h with green CI and no recent reviewer activity.
Non-blocking findings:
- MINOR | package.json:95 |
engines.node: ">=18"is now inconsistent with the dev toolchain, which requires Node >=22 (markdownlint-cli 0.49.1, markdownlint 0.41.1) and >=22.12.0 (commander 15.0.0), while CI still builds on Node 18.x/20.x. | A contributor (or CI job) withengine-strict=truein.npmrcon Node 18 or 20 getsnpm error code EBADENGINE ... commander@15.0.0 Required: {"node":">=22.12.0"}and the install aborts — reproduced locally against Node 20.20.2; the stale comment at.github/workflows/ci.yml:123also now understates the gap, since--ignore-enginesis needed for Node 20 too, not just Node 18.
escalated: needs a human-approved session (reason: body mentions 'migration')
Bumps smol-toml to 1.7.2 and updates ancestor dependency markdownlint-cli. These dependencies need to be updated together.
Updates
smol-tomlfrom 1.5.2 to 1.7.2Release notes
Sourced from smol-toml's releases.
... (truncated)
Commits
19239d0chore: bump version5f55c3achore: revert sourcemap publishing5c26f1bchore: update benchmarks92832d2refactor: better logic orchestration in structs2fb9ab8refactor: ctx object instead of pointer arg + tuple returnse6017c4ci: use staged publish3e978a9chore: bump versions30f5c36chore: add some@internalannotationsf0e0399chore(README.md): npmx, use star importa62f06frevert: keep using vite 7Updates
markdownlint-clifrom 0.47.0 to 0.49.1Release notes
Sourced from markdownlint-cli's releases.
Commits
5b5dddcBump version 0.49.14e83bddBump run-con from 1.3.2 to 1.3.34f2127bBump actions/setup-node from 6 to 7cc62492Manually address new violations reported by xo.678b7eeBump xo from 3.0.2 to 4.0.006602e9Bump ignore from 7.0.5 to 7.0.6eac32ddBump markdownlint from 0.41.0 to 0.41.12864eb0Bump js-yaml from 5.2.0 to 5.2.12748661Bump markdown-it from 14.2.0 to 14.3.00144ebeManually address new violations reported by xo.Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.
Summary by cubic
Bumps
smol-tomlto 1.7.2 andmarkdownlint-clito 0.49.1.smol-tomladds TOML 1.1.0 support, a faster parser, and fixes two security advisories;markdownlint-cliimproves several lint rules and removes inline directive handling that caused false positives.Migration
markdownlint-cli0.49.1 requires Node 22+, but the project'spackage.jsonstill declares"node": ">=18".smol-tomlstringify now always emits integers beyond the safe range as float numbers.Written for commit 161e68a. Summary will update on new commits.