Repository navigation
ci: minimal GitHub Actions for PRs and main - #57
Merged
Merged
Conversation
Ubuntu jobs run the standalone shared-core boundary check, evaluate the root manifest, run the portable cargo test and the remote-runner tests. A macos-26 job runs test.sh quick and skips docs-only changes. check-boundaries.sh falls back to swift when xcrun is absent. Refs #52 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 796841cfed
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #52
What runs
CI (
.github/workflows/ci.yml, ubuntu-24.04, every PR and push tomain)Shared-core boundaries: fullCore/scripts/check-boundaries.shin aswift:6.2-noblecontainer. The rootdump-packageevaluates declarations only (Sparkle is never resolved), so the root/core parity assertions run on Linux too.Portable runtime (cargo test):Core/Portable/test.shwith CMake 3.31.6 / Ninja 1.11.1.4 via pipx and therust-toolchain.tomlpin.build/portableis cached.Remote runner tests:python3 -B scripts/tests/test_mac_remote.py.macOS (
.github/workflows/macos.yml,macos-26,paths-ignore: ['**.md', 'docs/**'])quickgroup minusai-runtime(see below).test.sh allstays manual.build/deps,build/dictionary-sourcesandbuild/rime-cacheare cached. The job summary lists everyEND unit (Ns)line, and a failing unit is surfaced as an error annotation on the PR.Why no root
swift buildon ubuntuNo root target compiles on Linux:
InkFlowDomainimports CryptoKit, the app targets import AppKit/InputMethodKit, Sparkle ships as an xcframework and librime is a macOS dylib. The boundary check evaluates both manifests; the macOS job compiles the root products the quick units need. Documented in a workflow comment.Why
ai-runtimeis excluded on the runnerAIRuntimeTestsasserts the 500 ms debounce deadline at 540 ms. The first full attempt (run 37725452756) failed atAIRuntimeTests.swift:214with exactly that margin; the earlier debounce checks in the same binary passed. The workflow comment says so and names the list to keep in step withquick. This run doubles as the issue's failure record: the PR showsFAIL ai-runtime (18s)and the file:line as annotations.Other changes
check-boundaries.shusesswiftwhenxcrunis absent (Linux). Behavior on macOS is unchanged.macOS/TESTING.mddescribing what CI runs. Localtest.shis untouched.Timing
Repo is public, so the Actions timing API reports
billable.MACOS.total_ms = 0for every run; no minutes are consumed.dependencies.sh+prepare-rime.sh, then quality-store 90s, engine-basic 76s (incl. engine-tests build), engine-options 27s, engine-english 28s, engine-context 19s, controller 37s, settings 6s; cache save 19sBoth timing-API reads (failed run 37725452756 and green run 37726038434) report
billable.MACOS.total_ms = 0.🤖 Generated with Claude Code