Repository navigation
ci: build and link the Linux Fcitx5 plugin - #64
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
nervouna
added this pull request to stack #65
October 12, 2026 07:07
nervouna
force-pushed
the
ci/fcitx5-plugin-build
branch
from
October 12, 2026 07:08
db28676 to
fbc682f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #63 tests the portable core and standalone frontend helpers without compiling or linking the Fcitx5 plugin. This adds the actual CMake configure, plugin build/link and CTest steps to the existing Linux
portablejob, reusing the debug Rust static library produced bytest.sh/abi.shand the pinnedlibrime.so. There is no second Rust or Rime build. The C++ addon uses Release,--no-undefinedrejects unresolved addon/ABI symbols, and CTest fails if no tests are found.The portable job uses Ubuntu 26.04's Fcitx5 5.1.19 development packages. Ubuntu 24.04's Fcitx5 5.1.7 lacks
CandidateWord::setComment, as demonstrated by the build failure. The native cache is scoped to Ubuntu 26.04 to avoid restoring outputs from the previous distribution toolchain. Other jobs and the portable check name are preserved. Production code, release packaging, existing isolated tests and ARM64 Omarchy verification records are unchanged.Validation
At
db2867679bb8ed4ff88f2ad622275cfa9921e203:libinkflow.sowith Fcitx5 5.1.19,cargo/debug/libinkflow_rime.aand the pinnedlibrime.so. The verbose command confirms--no-undefined. CTest passed 1/1, with-UNDEBUGpreserving helper assertions in Release.test.sh quick: passed.git diff --checkpassed. The 20 installer tests passed withTMPDIR=/private/tmp; macOS's default/varalias initially exposed an existing canonical-path comparison in the test.actionlint1.7.12 passed with only the independently verifiedubuntu-26.04label warning suppressed, since its label list does not include that hosted runner yet.Coverage boundary
This PR targets
portable-coreata385c59, so its review contains only the CI and documentation changes. It does not merge #63 or this PR.Refs #63, #36.