fix(PL-6888): fix chart common labels

[davidmdm]

Summary by CodeRabbit

• Bug Fixes

  • Corrected the rendering of configured common labels in Deployment manifests.
  • Ensured labels are nested under the appropriate metadata section and consistently applied to generated resources.

• Tests

  • Added coverage validating common-label configuration across generated Kubernetes resources, including workloads, services, access controls, and custom resource definitions.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 77671b85-024a-4751-b7ab-11c8bc7e9c1e

📥 Commits

Reviewing files that changed from the base of the PR and between 3560f64 and 2c8129f.

📒 Files selected for processing (3)

• chart/templates/deployment.yaml
• chart/tests/common-labels/expected.yaml
• chart/tests/common-labels/values.yaml

---

📝 Walkthrough

Walkthrough

The chart corrects indentation for commonLabels in deployment pod metadata and adds test values plus the expected rendered Kubernetes manifests containing the configured label.

Changes

Common label rendering

Layer / File(s)	Summary
Common label configuration and template rendering chart/templates/deployment.yaml, chart/tests/common-labels/values.yaml	Defines nesto.ca/test: test and renders it under deployment pod labels with corrected indentation.
Generated manifest expectations chart/tests/common-labels/expected.yaml	Adds the expected CRDs, workload, RBAC, Service, and ServiceAccount manifests, including the configured common label.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: silphid

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: fixing chart common labels.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/PL-6888/fix-syncPolicy-defaults

---

_{Comment @coderabbitai help to get the list of available commands.}