Skip to content

fix(PL-6888): fix struct tags for applicationSource#19

Merged
davidmdm merged 1 commit into
masterfrom
fix/PL-6888/fix-syncPolicy-defaults
Jul 17, 2026
Merged

fix(PL-6888): fix struct tags for applicationSource#19
davidmdm merged 1 commit into
masterfrom
fix/PL-6888/fix-syncPolicy-defaults

Conversation

@davidmdm

@davidmdm davidmdm commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Bug Fixes
    • Improved application configuration serialization by omitting empty source paths, charts, and Helm settings.
    • Prevents unnecessary empty fields from appearing in generated configuration data.

@davidmdm
davidmdm requested a review from silphid July 17, 2026 16:47
@davidmdm
davidmdm enabled auto-merge (rebase) July 17, 2026 16:47
@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 2303abc9-1b0d-4b45-a1ed-c9f724cffb8a

📥 Commits

Reviewing files that changed from the base of the PR and between 75f6a30 and b08e6b8.

📒 Files selected for processing (1)
  • cmd/operator/argocd/application.go

📝 Walkthrough

Walkthrough

ApplicationSource now omits empty path and chart values and zero-valued helm data during JSON serialization.

Changes

Application source serialization

Layer / File(s) Summary
Omit empty source fields
cmd/operator/argocd/application.go
Path and Chart use omitempty; Helm uses omitzero in their JSON tags.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: silphid

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/PL-6888/fix-syncPolicy-defaults

Comment @coderabbitai help to get the list of available commands.

@davidmdm
davidmdm merged commit 86d28f8 into master Jul 17, 2026
5 of 6 checks passed
@davidmdm
davidmdm deleted the fix/PL-6888/fix-syncPolicy-defaults branch July 17, 2026 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants