Skip to content

fix/PL 6888/fix syncPolicy defaults#21

Merged
davidmdm merged 1 commit into
masterfrom
fix/PL-6888/fix-syncPolicy-defaults
Jul 17, 2026
Merged

fix/PL 6888/fix syncPolicy defaults#21
davidmdm merged 1 commit into
masterfrom
fix/PL-6888/fix-syncPolicy-defaults

Conversation

@davidmdm

@davidmdm davidmdm commented Jul 17, 2026

Copy link
Copy Markdown
Contributor
  • fix(PL-6888): argocd struct tags and force conflicts
  • fix(PL-6888): fix syncOptions serialization

Summary by CodeRabbit

  • Bug Fixes
    • Empty synchronization options are now omitted from generated configuration output, resulting in cleaner manifests.

@davidmdm
davidmdm force-pushed the fix/PL-6888/fix-syncPolicy-defaults branch from 1fd4c16 to b7ccb5d Compare July 17, 2026 17:56
@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 7d33d6ba-8c7a-4635-bb52-90df05214a98

📥 Commits

Reviewing files that changed from the base of the PR and between 0797c6c and b7ccb5d.

📒 Files selected for processing (1)
  • cmd/operator/argocd/application.go

📝 Walkthrough

Walkthrough

The SyncPolicy.SyncOptions JSON tag now uses omitempty, allowing empty sync options to be omitted from serialized Argo CD application output.

Changes

Argo CD serialization behavior

Layer / File(s) Summary
Sync options serialization contract
cmd/operator/argocd/application.go
SyncPolicy.SyncOptions now omits the syncOptions field when empty during JSON serialization.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: silphid

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/PL-6888/fix-syncPolicy-defaults

Comment @coderabbitai help to get the list of available commands.

@davidmdm
davidmdm requested a review from silphid July 17, 2026 17:57
@davidmdm
davidmdm enabled auto-merge (rebase) July 17, 2026 17:57
@davidmdm
davidmdm merged commit e94237f into master Jul 17, 2026
5 of 6 checks passed
@davidmdm
davidmdm deleted the fix/PL-6888/fix-syncPolicy-defaults branch July 17, 2026 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants