Closes #797, Closes #798: Adopt pyproject.toml and an explicit Ruff configuration

[arthanson]

Fixes: #798 #797

Adds explicit ruff configuration along with pyproject.toml settings file to set those params. Also fixes ruff line length errors. Updated python versions to match NetBox.

[arthanson]

@claude /review Only report on issues of potential concern; we don't need commentary on anything that doesn't require further consideration.

[github-actions]

Claude finished @arthanson's task in 2m 34s —— View job

---

PR Review: #803 — Add explicit Ruff configuration

• Gather diff and examine changed files
• Review pyproject.toml configuration
• Review code changes
• Post findings

---

Two issues worth discussing before merging:

---

1. requires-python = ">=3.12" is a breaking change with no documentation

pyproject.toml:16

The old setup.py had no python_requires constraint — the package installed on any Python version. Setting >=3.12 will cause pip install pynetbox to silently fail (or refuse to install) for users on Python 3.10 or 3.11. While the CI matrix and current NetBox target 3.12+, there's a real installed base of users on older Pythons who would silently get no upgrade.

This warrants either:

• A major version bump (v8.0.0) so pip's version solver can exclude the new release for older Pythons, or
• A clear CHANGELOG/README entry so users are warned before upgrading.

---

2. preview = true in ruff config is semantically at odds with the stated goal

pyproject.toml:79

The comment explains that preview = true caused CI to go red on unmodified code between ruff releases, and the fix is to pin the effective rule set explicitly. But preview = true is still set — it just means the scope of instability is now limited to the selected namespaces (E1, E2, RET, UP, etc.) rather than all rules.

New preview rules can still be added to those namespaces in a future ruff point release and break CI on unmodified code — which is exactly the problem the comment describes. The only fully stable configurations are:

• Pin ruff (already done) and drop preview = true, or
• Keep preview = true and accept that bumping the ruff pin requires a lint-clean check.

The current setup (pinned ruff + preview = true + explicit selects) works fine today but leaves a trap for whoever next bumps the ruff pin in requirements-dev.txt and .pre-commit-config.yaml.

---

Everything else (import-order normalization, else-after-return removals, % → .format() migration, setup.py → pyproject.toml migration, doc rewraps) looks correct and clean.

[arthanson]

Per claude review: 1. it is more correct to pin the version number. 2. is just the comments - pyproject.toml is from netbox.

[pheus]

Thanks for the clean-up, Arthur. This is in much better shape now.

I’m requesting changes because a few parts of the migration are still incomplete.

[pheus]

Thanks for the follow-up work!