Improve Edit tool: smallest old_string guidance, CRLF normalization, detailed errors, read-before-edit#1183
Merged
Merged
Conversation
Collaborator
lewis617
commented
Jun 1, 2026
lewis617
commented
- Add 'smallest old_string' guidance to Edit tool prompt (2-4 adjacent lines)
- Normalize CRLF to LF before matching so models can use LF in old_string
- Include attempted old_string in error message (truncated to 200 chars)
- Enforce read-before-edit: reject edits to files not in filesInContext
- Add hasFileInContext() method to MessageManager
- Update specs/001-fs-tools with FR-020 through FR-023
…detailed errors, read-before-edit - Add 'smallest old_string' guidance to Edit tool prompt (2-4 adjacent lines) - Normalize CRLF to LF before matching so models can use LF in old_string - Include attempted old_string in error message (truncated to 200 chars) - Enforce read-before-edit: reject edits to files not in filesInContext - Add hasFileInContext() method to MessageManager - Update specs/001-fs-tools with FR-020 through FR-023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.