fix: replay conversation history via session/update on session/load#1186
Merged
Conversation
loadSession() now replays the full conversation history via user_message_chunk, agent_message_chunk, agent_thought_chunk, and tool_call/tool_call_update notifications before returning, as required by the ACP v1 spec. Uses agent.getFullMessageThread() for complete history including compacted sessions, with fallback to agent.messages. Fixes #1185
Covers: tool without id, failed tool, tool without name, unparseable parameters, running stage, and skipped block types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1185
session/loadnow replays the full conversation history viasession/updatenotifications before returning, as required by the ACP v1 spec.Changes
replayConversationHistory()method that iterates the agent's message history and emits ACP notifications:user_message_chunkfor user text blocksagent_message_chunkfor assistant text blocksagent_thought_chunkfor reasoning blockstool_call+tool_call_updatefor tool blocks (with proper status, content, locations)agent.getFullMessageThread()for complete history including compacted sessions, with fallback toagent.messagesisMetamessages during replayacp-load-replay.ts)Test plan