Skip to content

Align skill content format with Claude Code #1190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lewis617 merged 2 commits into from
Jun 4, 2026
Merged

Align skill content format with Claude Code #1190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
acffa7a
Align skill content format with Claude Code
lewis617 Jun 4, 2026
6a5a3ad
Update skill manager tests to match new output format
lewis617 Jun 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions packages/agent-sdk/src/managers/skillManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,7 +382,7 @@ export class SkillManager extends EventEmitter {
} catch (error) {
logger?.error(`Failed to execute skill '${skill_name}':`, error);
return {
content: `❌ **Error executing skill**: ${error instanceof Error ? error.message : String(error)}`,
content: `**Error executing skill**: ${error instanceof Error ? error.message : String(error)}`,
};
}
}
Expand All @@ -404,14 +404,14 @@ export class SkillManager extends EventEmitter {

if (!skill) {
return {
content: `❌ **Skill not found**: "${skill_name}"\n\nAvailable skills:\n${this.formatAvailableSkills()}`,
content: `**Skill not found**: "${skill_name}"\n\nAvailable skills:\n${this.formatAvailableSkills()}`,
};
}

if (!skill.isValid) {
const errorMsg = formatSkillError(skill.skillPath, skill.errors);
return {
content: `❌ **Skill validation failed**:\n\n\`\`\`\n${errorMsg}\n\`\`\``,
content: `**Skill validation failed**:\n\n\`\`\`\n${errorMsg}\n\`\`\``,
};
}

Expand All @@ -420,7 +420,7 @@ export class SkillManager extends EventEmitter {
} catch (error) {
logger?.error(`Failed to prepare skill '${skill_name}':`, error);
return {
content: `❌ **Error preparing skill**: ${error instanceof Error ? error.message : String(error)}`,
content: `**Error preparing skill**: ${error instanceof Error ? error.message : String(error)}`,
};
}
}
Expand All @@ -429,9 +429,7 @@ export class SkillManager extends EventEmitter {
* Prepare skill content with arguments but without bash execution
*/
private prepareSkillContent(skill: Skill, argsString: string): string {
const header = `🧠 **${skill.name}** (${skill.type} skill)\n\n`;
const description = `*${skill.description}*\n\n`;
const skillPath = `📁 Skill location: \`${skill.skillPath}\`\n\n`;
const skillPath = `Base directory for this skill: ${skill.skillPath}\n\n`;

// Extract content after frontmatter
const contentMatch = skill.content.match(/^---\n[\s\S]*?\n---\n([\s\S]*)$/);
Expand All @@ -451,7 +449,7 @@ export class SkillManager extends EventEmitter {
);
}

return header + description + skillPath + mainContent;
return skillPath + mainContent;
}

/**
Expand Down
20 changes: 9 additions & 11 deletions packages/agent-sdk/tests/managers/skillManager.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,10 +488,8 @@ describe("SkillManager", () => {
});

expect(result.content).toContain(
"🧠 **test-plugin:test-skill** (personal skill)",
"Base directory for this skill: /path/to/skill",
);
expect(result.content).toContain("*A test skill*");
expect(result.content).toContain("📁 Skill location: `/path/to/skill`");
expect(result.content).toContain("# Actual Content");
expect(result.content).not.toContain("---");
});
Expand Down Expand Up @@ -523,9 +521,9 @@ describe("SkillManager", () => {
});

expect(result.content).toContain(
"🧠 **test-plugin:fork-skill** (personal skill)",
"Base directory for this skill: /path/to/skill",
);
expect(result.content).not.toContain("🔄 Context: `fork`");
expect(result.content).not.toContain("fork");
expect(result.content).toContain("# Actual Content");
});

Expand Down Expand Up @@ -629,9 +627,9 @@ describe("SkillManager", () => {
skill_name: "test-skill",
});

expect(result.content).toContain("🧠 **test-skill**");
expect(result.content).toContain("personal skill");
expect(result.content).toContain("A test skill");
expect(result.content).toContain(
"Base directory for this skill: /path/to/skill",
);
expect(result.content).toContain("# Test Content");
expect(result.context).toEqual({ skillName: "test-skill" });
});
Expand Down Expand Up @@ -681,7 +679,7 @@ describe("SkillManager", () => {
});

expect(result.content).toContain(
'❌ **Skill not found**: "nonexistent-skill"',
'**Skill not found**: "nonexistent-skill"',
);
expect(result.content).toContain("Available skills:");
expect(result.content).toContain("available-skill");
Expand Down Expand Up @@ -710,7 +708,7 @@ describe("SkillManager", () => {
skill_name: "invalid-skill",
});

expect(result.content).toContain("❌ **Skill validation failed**");
expect(result.content).toContain("**Skill validation failed**");
expect(result.content).toContain("Formatted Error");
});

Expand All @@ -724,7 +722,7 @@ describe("SkillManager", () => {
});

expect(result.content).toContain(
"❌ **Error preparing skill**: Loading failed",
"**Error preparing skill**: Loading failed",
);
expect(logger.error).toHaveBeenCalledWith(
"Failed to prepare skill 'error-skill':",
Expand Down