feat: add MCP server tab to configuration dialog#60
Merged
Conversation
Contributor
lewis617
commented
May 19, 2026
lewis617
commented
- Add MCP tab in ConfigurationDialog to view and manage MCP servers
- Display server status (connected/disconnected/connecting/error), tool count, and connection details
- Support connect/disconnect buttons with loading state for each server
- Show empty state with .mcp.json configuration hint when no servers configured
- Backend: add getMcpServers/connectMcpServer/disconnectMcpServer handlers in messageHandler and chatSession
- Update spec.md with MCP tab features and three-tab structure description
- Add e2e demo tests for MCP tab: server list, empty state, and connect/disconnect actions
- Add MCP tab in ConfigurationDialog to view and manage MCP servers - Display server status (connected/disconnected/connecting/error), tool count, and connection details - Support connect/disconnect buttons with loading state for each server - Show empty state with .mcp.json configuration hint when no servers configured - Backend: add getMcpServers/connectMcpServer/disconnectMcpServer handlers in messageHandler and chatSession - Update spec.md with MCP tab features and three-tab structure description - Add e2e demo tests for MCP tab: server list, empty state, and connect/disconnect actions
…dates The previous implementation manually fetched MCP servers after connect/disconnect, which returned stale 'disconnected' state since the connection is asynchronous. SDK's onMcpServersChange callback fires after the connection completes, but was not registered. Fix: - Register onMcpServersChange in ChatSession's AgentCallbacks (wave-agent pattern) - Forward callback through ChatProvider to webview via 'mcpServersUpdate' message - ConfigurationDialog now handles both mcpServersResponse (initial) and mcpServersUpdate (push) commands - Remove redundant manual getMcpServers calls in messageHandler - Update notification message to clarify it indicates request sent, not completion
- Display formatted JSON parameters in confirmation dialog for MCP tools (mcp__*) - Match wave-agent's behavior of showing tool parameters for user review - Add section 4.4 MCP Tool Confirmation to spec.md - Add MCP confirmation demo screenshot to product-spec-confirmations.demo.ts - Update section 6.3 MCP integration to reference the confirmation dialog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.