Conversation
DCM report✅ no issues found! Full report: https://github.com/netglade/flutter_core/runs/59767331308 |
There was a problem hiding this comment.
Pull request overview
This PR updates DCM (Dart Code Metrics) from version 1.33.0 to 1.35.0, incorporating new lint rules and updating test files to comply with the new linting requirements, particularly the prefer-test-structure rule which enforces the Arrange-Act-Assert (AAA) pattern.
- Updates DCM version to 1.35.0 and adds 4 new lint rules
- Modifies maintainability-index metric from 50 to 0.5 to align with DCM's updated configuration format
- Restructures test files to follow the AAA pattern with explicit comment sections
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
dcm_global.yaml |
Updates DCM version from 1.33.0 to 1.35.0 |
packages/netglade_analysis/pubspec.yaml |
Bumps package version to 21.0.0 |
packages/netglade_analysis/lib/dcm.yaml |
Adds 4 new lint rules and updates maintainability-index metric to 0.5 |
packages/netglade_analysis/CHANGELOG.md |
Documents changes for version 21.0.0 |
packages/netglade_analysis/README.md |
Updates version reference to 21.0.0 |
packages/netglade_utils/pubspec.yaml |
Updates netglade_analysis dependency to ^21.0.0 |
packages/netglade_utils/example/pubspec.yaml |
Updates netglade_analysis dependency to ^21.0.0 |
packages/netglade_flutter_utils/pubspec.yaml |
Updates netglade_analysis dependency to ^21.0.0 |
packages/netglade_flutter_utils/example/pubspec.yaml |
Updates netglade_analysis dependency to ^21.0.0 |
packages/netglade_utils/test/src/extensions/string_extensions_test.dart |
Restructures tests to follow AAA pattern with explicit comments |
packages/netglade_utils/test/src/extensions/date_time_extensions_test.dart |
Restructures tests to follow AAA pattern and converts forEach to for-in loops |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/netglade_utils/test/src/extensions/date_time_extensions_test.dart
Show resolved
Hide resolved
packages/netglade_utils/test/src/extensions/date_time_extensions_test.dart
Outdated
Show resolved
Hide resolved
petrnymsa
approved these changes
Jan 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.