[NETOBSERV-2885][QE] Status page via OLM Page

[kapjain-rh]

Description

Test cases for change NETOBSERV-2693 Open Flowcollector status page from OLM page

Dependencies

n/a

Checklist

• Does the changes in PR need specific configuration or environment set up for testing?
  • if so please describe it in PR description.
• I have added thorough unit tests for the change.
• QE requirements (check 1 from the list):
  • Standard QE validation, with pre-merge tests unless stated otherwise.
  • Regression tests only (e.g. refactoring with no user-facing change).
  • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Summary by CodeRabbit

• Tests
  • Expanded end-to-end coverage for FlowCollector navigation and lifecycle actions.
  • Added validation for status indicators on Network Health and Network Traffic pages.
  • Covered editing, opening Network Traffic, canceling deletion, and deleting a FlowCollector.
  • Added automated coverage for creating and deleting FlowCollectors, including confirmation dialogs.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 89ad0dbb-70e4-480b-acff-08364ada324d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

📝 Walkthrough

Walkthrough

Added Cypress coverage for FlowCollector navigation, status indicators, editing, Network Traffic access, deletion cancellation, and deletion confirmation. Added page-object selectors and navigation helpers for these flows.

Changes

FlowCollector Cypress coverage

Layer / File(s)	Summary
Navigation and status actions web/cypress/integration-tests/static_plugin.cy.ts, web/cypress/views/flowcollector-status.ts	Tests cover OLM navigation, ready-state indicators, tooltips, editing, and opening Network Traffic. Page helpers support cluster and non-ready status-page visits.
Deletion lifecycle validation web/cypress/integration-tests/static_plugin.cy.ts, web/cypress/views/flowcollector-status.ts	Selectors and tests cover the delete dialog, cancellation, confirmation, resource removal, empty-state messaging, and remaining controls.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

• netobserv/netobserv-web-console#1439: Introduced FlowCollector status Cypress tests and page-object selectors.
• netobserv/netobserv-web-console#1570: Added FlowCollector status navigation and lifecycle functionality covered here.
• netobserv/netobserv-web-console#1670: Implemented FlowCollector status, navigation, and deletion functionality validated by these tests.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the main change: testing the FlowCollector status page through OLM.
Description check	✅ Passed	The description includes the required sections and explains the test scope, with no dependencies or environment requirements listed.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[kapjain-rh]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@web/cypress/integration-tests/static_plugin.cy.ts`:
- Around line 85-88: Update the OLM navigation step in static plugin test to
click the visible “cluster” link instead of extracting its href and calling
cy.visit. Preserve the existing visibility assertion and timeout, and rely on
Cypress’s click/navigation behavior to exercise the user interaction.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 51c59202-fe2a-4550-b842-da273fb360e5

📥 Commits

Reviewing files that changed from the base of the PR and between 1c9bb11 and deed630.

📒 Files selected for processing (2)

• web/cypress/integration-tests/static_plugin.cy.ts
• web/cypress/views/flowcollector-status.ts

🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

• netobserv/netobserv-operator (manual)
• netobserv/flowlogs-pipeline (manual)

[kapjain-rh]

@Amoghrd @memodi, Please review

[Amoghrd]

Suggested change

	describe('Network_Observability FlowCollector status error scenario', { tags: ['Network_Observability'] }, function () {
	describe('FlowCollector status error scenario', { tags: ['Network_Observability'] }, function () {

[kapjain-rh]

I made this change to make it same as main

[kapjain-rh]

I will take care this in Next PR and will remove from main and as well as from here

[Amoghrd]

Sounds good

[Amoghrd]

Can you paste a passing run?

[kapjain-rh]

Please check :)
(Run Finished)

   Spec                                              Tests  Passing  Failing  Pending  Skipped  

┌────────────────────────────────────────────────────────────────────────────────────────────────┐
│ ✔ flowcollector_status.cy.ts 00:42 1 1 - - - │
├────────────────────────────────────────────────────────────────────────────────────────────────┤
│ ✔ static_plugin.cy.ts 02:06 5 5 - - - │
└────────────────────────────────────────────────────────────────────────────────────────────────┘
✔ All specs passed! 02:49 6 6 - - -

[Amoghrd]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• DOWNSTREAM_OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

New changes are detected. LGTM label has been removed.

[openshift-ci]

@kapjain-rh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/pf5-plugin-cypress	757c80d	link	true	/test pf5-plugin-cypress
ci/prow/pf5-images	757c80d	link	true	/test pf5-images
ci/prow/pf5-integration-tests	757c80d	link	false	/test pf5-integration-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.