Skip to content

docs(attest-release-files): name the signer workflow in the verify hint - #419

Merged
CybotTM merged 1 commit into
mainfrom
fix/attest-verify-signer
Sep 14, 2026
Merged

CybotTM merged 1 commit into
mainfrom
fix/attest-verify-signer

Conversation

@CybotTM

@CybotTM CybotTM commented Sep 14, 2026

Copy link
Copy Markdown
Member

Merging this corrects the verification hint in the header of attest-release-files.yml: the attestation is signed by this reusable workflow, so gh attestation verify --repo <owner>/<repo> alone checks the signer against the caller repository and fails. The hint now adds --signer-workflow netresearch/.github/.github/workflows/attest-release-files.yml. Comment-only change; follows #418, found in the review of netresearch/github-release-skill#122.

The attestation is signed by this reusable workflow, not by the caller.
`gh attestation verify --repo <owner>/<repo>` alone checks the signer
against the caller repository and fails; the header now passes
--signer-workflow with this workflow's path.

Assisted-by: claude-code:claude-opus-5
Agent-Session: https://claude.ai/code/session_012BSvdctvVZ6Yz6nYUAA2p7
Agent-Host: 32116e
Signed-off-by: Sebastian Mendel <sebastian.mendel@netresearch.de>
Copilot AI lite review requested due to automatic review settings September 14, 2026 13:32
@coderabbitai

coderabbitai Bot commented Sep 14, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: e12dc997-92c5-423e-979a-3643c175e1ad

📥 Commits

Reviewing files that changed from the base of the PR and between 163192b and f8e904a.

📒 Files selected for processing (1)
  • .github/workflows/attest-release-files.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The verification documentation now includes --signer-workflow with --repo. This identifies the reusable attestation workflow used to sign the release files.

Priority: ⬇️ Low

Change: Other

Merge Risk: ⚪ Minimal · up to f8e90

The verification instructions now identify the workflow that signs the release artifacts, with no remaining merge-blocking risk.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the change, its reason, and its scope. However, it does not use the required template sections for Summary, Type of Change, Checklist, and Test Plan. Rewrite the description using the repository template. Include the Summary, Type of Change, Checklist, and Test Plan sections. Mark Documentation update as the change type and record the applicable checklist items.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the documentation change: naming the signer workflow in the verification hint.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/attest-verify-signer
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch fix/attest-verify-signer

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@CybotTM

CybotTM commented Sep 14, 2026

Copy link
Copy Markdown
Member Author

Self-review: f8e904a

The review this pull request demands is unsatisfiable (Copilot quota wall or repeated bot failures on this head). Per the documented fallback, the diff on this head was reviewed by the PR author; this comment is the on-the-record attestation the merge gate reads back. It stops matching on the next push.

@CybotTM
CybotTM merged commit 6f1243c into main Sep 14, 2026
13 of 14 checks passed
@CybotTM
CybotTM deleted the fix/attest-verify-signer branch September 14, 2026 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants