Fix docs typos#240
Open
wazsone wants to merge 1 commit into
Open
Conversation
d-uzlov
reviewed
Jan 10, 2023
| Examples of Network Services would include: | ||
|
|
||
| - A simple distributed vL3 that allows the workloads to communicate via IP, optionally with DNS service for that vL3 | ||
| - A simply distributed vL3 that allows the workloads to communicate via IP, optionally with DNS service for that vL3 |
There was a problem hiding this comment.
I think here the original text doesn't have a typo, so this change should be reverted.
Maybe a better wording would be something like this:
A simple distributed vL3 network that allows
| that the HTTPS message itself gets to the other side and the HTTPS response gets back to the workload. In the intervening process | ||
| the ethernet headers, ip headers, and even the TCP connection may have been stripped away and replaced. The payload being tranported | ||
| Traditional Service Meshes predominantly focus on L7 payloads like HTTPS. If a workload sends an HTTPS message, it only guarantees | ||
| that the HTTPS message itself gets to the other side and the HTTPS response gets back to the workload. In the intervening process, |
There was a problem hiding this comment.
Do we need this comma?
I'm no an expert in English grammar so I may be wrong but it feels like it shouldn't be here.
| of Zero Trust: | ||
|
|
||
| > In essence, a Zero Trust Architecture allows users full access but only to the bare minimum they need to perform their jobs. If a device is compromised, zero trust can ensure that the damage is contained. | ||
| > In essence, a Zero Trust Architecture allows users full access but only the bare minimum they need to perform their jobs. If a device is compromised, zero trust can ensure that damage is contained. |
There was a problem hiding this comment.
I think the original meaning is to the bare minimum [of functionality], so this to was correct.
| indicating which IPs should be routed from the Pod to the Network Service. | ||
|
|
||
| In order to avoid IP collisions, NSM prevents the use of IP addresses or routes from Prefixes in use in the cluster. | ||
| To avoid IP collisions, NSM prevents the use of IP addresses or routes from Prefixes in use in the cluster. |
There was a problem hiding this comment.
It's the same meaning but I think the original wording sounds better.
| App foo needs to stay in deployment in the interim. | ||
|
|
||
| An expensive IPS can provide protection from the vulnerability. By keying off of labels provided by the {{<color "#0050EF" >}}Clients{{< /color >}} when | ||
| An expensive IPS can protect from vulnerability. By keying off of labels provided by the {{<color "#0050EF" >}}Clients{{< /color >}} when |
Contributor
There was a problem hiding this comment.
I think it was correct
|
|
||
| What Runtime Domain a workload is running in is a [non-sequitur](https://en.wikipedia.org/wiki/Non_sequitur_(literary_device)) to its communications needs. Workloads that are part of | ||
| the same App need Connectivity between each other no matter where they are running. | ||
| the same App need Connectivity with each other no matter where they are running. |
Contributor
There was a problem hiding this comment.
I think it was correct
| Traditional Service Meshes predominantly focus on L7 payloads like HTTPS. If a workload send an HTTPS message, they only guarantee | ||
| that the HTTPS message itself gets to the other side and the HTTPS response gets back to the workload. In the intervening process | ||
| the ethernet headers, ip headers, and even the TCP connection may have been stripped away and replaced. The payload being tranported | ||
| Traditional Service Meshes predominantly focus on L7 payloads like HTTPS. If a workload sends an HTTPS message, it only guarantees |
Contributor
There was a problem hiding this comment.
they only... - means Service Meshes
ThetaDR
reviewed
Jan 10, 2023
| ## The NSM Solution | ||
|
|
||
| Network Service Mesh allows individual workloads, where ever they are running to connect securely to Network Service(s) that | ||
| Network Service Mesh allows individual workloads, where ever they are run, to connect securely to Network Service(s) that |
There was a problem hiding this comment.
I think it should be like:
workloads, wherever they are run to
There was a problem hiding this comment.
I'm not sure about run/running thing, but we either need to use commas on both sides of where ever they are running part, or on neither side.
And I think here we need it on both sides.
Member
|
@wazsone Could you please rebase this? |
wazsone
force-pushed
the
bug/fix-docs-typos
branch
3 times, most recently
from
be3bba0 to
512129b
Compare
Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru>
wazsone
force-pushed
the
bug/fix-docs-typos
branch
from
512129b to
3497130
Compare
Member
denis-tingaikin
left a comment
denis-tingaikin
left a comment
There was a problem hiding this comment.
@edwarnicke Could you have a look?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ruslan Bayandinov wazsone@ya.ru