Revise CXXFLAGS with SSL libs, and other build recipe nuances#3363
Open
jimklimov wants to merge 19 commits intonetworkupstools:masterfrom
Open
Revise CXXFLAGS with SSL libs, and other build recipe nuances#3363jimklimov wants to merge 19 commits intonetworkupstools:masterfrom
jimklimov wants to merge 19 commits intonetworkupstools:masterfrom
Conversation
…#3353] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…#3356] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…IBSSL_CXXFLAGS [networkupstools#1711, networkupstools#1599] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…olved [networkupstools#1599, networkupstools#1711] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…lients/Makefile.am, tests/Makefile.am: introduce separate automake condition and macro WITH_SSL_CXX [networkupstools#1599, networkupstools#1711] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…stools#1599] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
jimklimov
added
enhancement
documentation
C++
CI
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
❌ Build nut 2.8.4.4363-master failed (commit f65e31746f by @jimklimov) |
…ls#1599] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
… building without SSL_CXX [networkupstools#1599] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
|
✅ Build nut 2.8.4.4364-master completed (commit d5bb987c83 by @jimklimov) |
networkupstools#3008 Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…ECK_SRC_DEFAULT and comment why they may not be the first checked anyway [networkupstools#2871] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…SRC values [networkupstools#2871] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…S_FIRST (if present) even before parallel rules [networkupstools#2871] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…tent and easier for troubleshooting [networkupstools#2871, networkupstools#3039] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…networkupstools#3039] * Goal for "generated-headers-with-a-touch" stepped on "all" done as part of "check". * Not using `+` prefix in that goal was not right too. * Made cleanup dependencies separate for all/check/install recursive rules. Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…device [networkupstools#3356] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
|
❌ Build nut 2.8.4.4365-master failed (commit f36ce66408 by @jimklimov) |
…enerated headers to generated linkman*.txt snippets, to avoid re-evaluating them verbosely in parallel/recursive builds [networkupstools#2871] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
jimklimov
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not only Termux, but also MSYS2 hiccups with at least OpenSSL builds with C++ (pkgconfig-provided
CFLAGSinvolve-isystemwhich breaks loose with#include_nextin C++ versions of headers).This PR follows up from recent work in #3353 for issues #1599/#1711, to handle this more diligently and generally (to the point of not trying to build and test SSL ability in C++
libnutclientif we determine atconfiguretime that we can not reliably build it).Also brings in some parallel build/check recipe fixes to follow up from #2871 and small docs patches per #3356 discussion.