This repository was archived by the owner on May 1, 2024. It is now read-only.
Open
Conversation
Contributor
Author
|
Should I write some tests for this? Or is something else keeping this from a merge? |
dschult
reviewed
Nov 17, 2019
Member
dschult
left a comment
There was a problem hiding this comment.
Sorry this is not getting much attention.
Here's a review:
-
I'm not sure this change will work with the METIS adjacency_list data structure. But I assume you have checked that it works. Can you add some tests -- they will both check that something doesn't mess it up later, and serve as a very basic form of documentation of how it should work.
-
dict(G[u])[v] should be simplified to G[u][v] ... or you could make the inner loop:
for v, keydict in G[u].items():
adjncy.extend(index[v] for key in keydict)
- docstrings for private functions don't matter much, but could you change _convert_multi_graph and _convert_graph to docstrings like:
"""Convert a Graph to the numbered adjacency list expected by METIS.
"""
That way they are a single line and under 80 chars so Sphinx and pycodestyle are happy.
- To allow subclasses of networkx graphs, replace ```if(isinstance(G,nx.MultiGraph)):``` with ```if G.is_multigraph()):```
Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #62