[ryoku] update: sweep WirePlumber drop-ins Ryoku no longer ships - #36
Open
neur0map wants to merge 1 commit into
Open
[ryoku] update: sweep WirePlumber drop-ins Ryoku no longer ships#36neur0map wants to merge 1 commit into
neur0map wants to merge 1 commit into
Conversation
materialize pruned only paths the previous manifest recorded, and deploy.sh copies configs without writing that manifest, so a checkout-deployed box kept a withdrawn drop-in forever and wpConfigPruned never fired to restart WirePlumber. The global ALSA soft-mixer override outlived its removal in 280fc65 that way: api.alsa.soft-mixer=true stayed live, PipeWire left the hardware mixer alone, and playback sat at whatever level the card booted with while every control still read 100%. Converge wireplumber.conf.d against the shipped set, matched on the NN-ryoku-*.conf naming so the user's own drop-ins there are left alone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hit this on my own box today: game audio and browser both way quieter than they
should be, every control reading 100% and unmuted.
50-ryoku-alsa-soft-mixer.confwas still sitting in~/.config/wireplumber/wireplumber.conf.d/, 11 days after I deleted it in280fc65.
api.alsa.soft-mixer=truewas still live on the sink, so PipeWire wasdoing volume in software and never touching the hardware mixer. The slider read
100% because it was passing samples through untouched, while the card sat at
whatever level it booted with.
ryoku-restart-audiowas no help, it justre-reads the same config.
Cause:
materializeprunes only what the previous manifest recorded, anddeploy.shcopies configs without writing that manifest. On a checkout-deployedbox the file was never in the manifest, so prune couldn't see it and it survived
every update.
wpConfigPrunednever flipped either, so the WirePlumber restartnever fired.
Fix: converge
wireplumber.conf.dagainst the shipped set instead of trustingthe manifest, same idea as what
quickshell/already does. Can't sweep the wholedirectory since users keep their own overrides there, so it matches the
NN-ryoku-*.confnaming all our drop-ins use and leaves everything else alone.New test fails without the change, passes with.
TestChannelStatusNoCheckoutalready fails on main, unrelated to this.