feat(data): DataSpec validation, Croissant fix, MPS guard#376
Open
dhritimandas wants to merge 6 commits intoneuronets:alphafrom
Open
feat(data): DataSpec validation, Croissant fix, MPS guard#376dhritimandas wants to merge 6 commits intoneuronets:alphafrom
dhritimandas wants to merge 6 commits intoneuronets:alphafrom
Conversation
Add versioned dataset contract with DataLad-aware preflight validation: - DataSpec dataclass with JSON serialization - validate() with symlink-aware file checks, spacing/orientation/label validation - inspect_entry() for NIfTI/Zarr metadata inspection - CLI commands: validate, inspect, --skip-validate on predict/convert-to-zarr - 33 unit tests covering all branches
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #374
Summary
DataSpecdataclass with JSON serialization,validate()with symlink-aware file checks (DataLad/git-annex), spacing/orientation/label class validation,inspect_entry()for NIfTI/Zarr metadata. New CLI commands:validate,inspect,--skip-validateonpredict/convert-to-zarr.@contextdicts with official Croissant 1.0 context (CROISSANT_CONTEXTconstant), fix@typetosc:Dataset, addconformsToandsha256fields required bymlcroissantvalidation.conftest.pywhen Conv3D is unsupported (PyTorch < 2.3 on Apple Silicon).Test plan
pytest nobrainer/tests/unit/ -m "not gpu")pytest nobrainer/sr-tests/ -m "not gpu")python -c "import nobrainer"succeeds